Fixed HasOffsetValueType accessory missing main-type
#4162
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been marked as ready for review. |
staabm
force-pushed
the
bug13270_mixed
branch
3 times, most recently
from
009847e to
cb3f21b
Compare
|
This pull request has been marked as ready for review. |
|
required a bit exploring, and back and forth. reduced the scope of the PR a bit and will send followups instead to keep this one simple. @ondrejmirtes I think we are good to go now :) |
|
Thank you! |
|
I decided for a different approach here: 56a30c2 My reasoning is in the commit description. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR does not fix the initial reported error of the OP in phpstan/phpstan#13270 (comment) (which I think is a valid error)
but I as I understood ondrej's examples in phpstan/phpstan#13270 (comment) it fixes the typing problems
closes phpstan/phpstan#13270